Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require tomli at install time #104

Merged
merged 1 commit into from
Dec 14, 2023
Merged

require tomli at install time #104

merged 1 commit into from
Dec 14, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Dec 14, 2023

The local tests passed (possibly because tomli was listed in requirements.txt?) but the released version did not work on python 3.10 and older.

@jepler jepler requested a review from dhalbert December 14, 2023 16:59
dhalbert
dhalbert approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@dhalbert dhalbert merged commit bcb5427 into adafruit:main Dec 14, 2023
1 check passed
@jepler jepler deleted the require-tomli-setup.py branch December 14, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @dhalbert